Update mathjax w/ npm auto-update #1762
Conversation
packages/m/mathjax.json
Outdated
| @@ -20,7 +20,14 @@ | |||
| { | |||
| "basePath": "", | |||
| "files": [ | |||
| "es5/**/!(node-main.js)", | |||
| "**/!(node-main.js)", | |||
There was a problem hiding this comment.
We tend to avoid globstars, and especially open ones -- this line is now basically saying "add every file ever, except node-main.js", which I suspect is not what you want?
There was a problem hiding this comment.
3.x.x has the es5 directory, if we do not need to think about it, we can apply this change, thanks for reply.
There was a problem hiding this comment.
I'm not sure I follow what you're saying. You have changed es5/**/!(node-main.js) to be **/!(node-main.js). **/!(node-main.js) is going to match every file in the package, which is not acceptable and I will not merge such a change. Please fix the config to just match the files that're required.
There was a problem hiding this comment.
I'm sorry, I misunderstood what you said :(
I have corrected the mistake.
Should fix #1669, #1694
As described in #1694
But 4.x is still a beta version and there is no stable 4.x release yet, so I'm not sure we should do the update now.
Please merge as appropriate, thanks