Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not working] Try upgrading to OAPIv3.1 #653

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

essential-randomness
Copy link

This is not a real PR, but I did some work to see what would be needed to upgrade to Open API v3.1 and don't want it to be lost to time.

As far as I can tell, the AJV/OpenAPIv3.1 combo doesn't seem to be correctly working right now, as I eventually realized I can't even get the OpenAPI example to validate with AJV. This is the issue I filed on the AJV repo: ajv-validator/ajv#1745

Other things I've learned:

The file I've dedicated most of my attention to is src/framework/openapi.schema.validator.ts. You can see here the options I've passed to AJV, which are also attached to the issue filed. An explanation for those can be found here: OAI/OpenAPI-Specification#2489

I'll see how the discussion with the AJV folks goes (and then with the OpenAPI folks as needed), but it's unknown whether I'll pick this back up. Hopefully, however, this initial investigation is useful for someone.

Sorry for the mess in these files! I tried a lot of different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant