Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Enable Github Actions CI CMake build #176

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

sisco0
Copy link

@sisco0 sisco0 commented Jan 30, 2022

This PR solves #173 secondary task, which enables CI to be integrated into the project.

The enablement of this CI workflow would give the project development process more quality and consistency over inter-release updates. Also, take into account that testing is enabled but could not be run for local processes, as Github Actions runners do not contain GPU.

This PR must be merged only after merging #174, it was created this way for separating tasks in the same issue.

A log of the CI test runs is presented at https://github.com/sisco0/AutoDock-GPU/actions where artefacts could be downloaded as well.

Click here to see Github Action run screen

image

@sisco0 sisco0 changed the title Feat/ci cmake build Feat/Enable Github Actions CI CMake build Jan 30, 2022
@sisco0 sisco0 changed the title Feat/Enable Github Actions CI CMake build feat/Enable Github Actions CI CMake build Jan 30, 2022
@atillack
Copy link
Member

atillack commented Feb 2, 2022

@sisco0 After some internal deliberations amongst our team we decided that we'd like to move forward with both the GH action and Cmake compilation you implemented in one PR.

As this PR is PR 174 + GH actions I would suggest closing PR 174 and to focus on adding any remaining work to this one.

Before merging, here is a list of features still missing:

  • compilation target and/or fallback for compiling in tool mode
  • release types and associated behavior (i.e. defines like DOCK_DEBUG)
  • (optional but would be great:) use CMake to create OpenCL code char array

@AenBleidd
Copy link

Any updated on this?
Would be very nice to have it merged, and optionally (this I might handle by myself) to have in decomposed into library + application that uses this library, since it might be helpful to anyone who would like to integrate your solution into their workflow more smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants