Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound extractors #371

Open
wants to merge 30 commits into
base: tools
Choose a base branch
from
Open

Compound extractors #371

wants to merge 30 commits into from

Conversation

pauladkisson
Copy link
Member

Awaiting #369 then will change base to 0.6.0dev.

This PR is the fifth of a series that implement breaking changes to fully standardize the roiextractors api and update/streamline the testing suite. Some of the main goals include

  • removing channels argument to enforce 1 channel/extractor
  • Switching to modularized mixins for testing and supporting pytest fixtures/parameterization
  • Standard input validation, numpy indexing for 'get' methods, etc.

This PR updates MultiImagingExtractor and VolumetricImagingExtractor and adds appropriate tests.
Originally, I was intending on updating MultiSegmentationExtractor as well, but none of the current segmentation extractors use this class, so its utility/requirements are very unclear rn.

@pauladkisson pauladkisson changed the base branch from main to tools October 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant