Update SegmentationExtractor #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ractmethods like imagingextractor does
bendichter
reviewed
Oct 31, 2024
| @@ -31,6 +31,7 @@ | |||
| DtypeType = DTypeLike | |||
| IntType = Union[int, np.integer] | |||
| FloatType = float | |||
| NoneType = type(None) | |||
There was a problem hiding this comment.
Is this used? Is it needed? I think generally None is used in typehinting to express the None type
bendichter
reviewed
Oct 31, 2024
| if image_masks.is_file(): | ||
| assert image_masks.suffix == ".npy", "'image_masks' file is not a numpy file (.npy)" | ||
| image_masks: Union[PathType, np.ndarray] | ||
| Binary image for each of the regions of interest. |
There was a problem hiding this comment.
The description doesn't seem to indicate what type of arg would take the Path type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting #365 then will change base to 0.6.0dev.
This PR is the second of a series that implement breaking changes to fully standardize the roiextractors api and update/streamline the testing suite. Some of the main goals include
This PR focuses on
SegmentationExtractor,FrameSliceSegmentationExtractor, andNumpySegmentationExtractor