Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Plane and Multi-Channel Support for ScanImage #253

Merged
merged 20 commits into from
Oct 26, 2023

Conversation

pauladkisson
Copy link
Member

Fixes #240
Continues from #241 rebased from #248

@pauladkisson pauladkisson changed the base branch from main to volumetric September 29, 2023 00:06
Base automatically changed from volumetric to main October 25, 2023 20:20
@pauladkisson
Copy link
Member Author

The one thing that I never really figured out is how to deal with the times for the volumetric imaging. Still not really sure how that should be represented. Right now the times are accessible in each SinglePlaneImagingExtractor. Other than that this should be good to go.

@CodyCBakerPhD
Copy link
Member

The one thing that I never really figured out is how to deal with the times for the volumetric imaging. Still not really sure how that should be represented.

It looks like our base classes themselves still need to be updated to the latest SI standard (get_times) so fine to leave that as a follow-up

I know we talked about having an array of times to indicate the shifts for each plane, but for consistency with the other methods like get_video, I think the simplest return for such a function would just be the timestamps of the first plane capture in each volume, for each frame

Then we can talk about a separate method for volumes that returns a more detailed structure and get feedback from the rest of the team on that

@CodyCBakerPhD
Copy link
Member

This LGTM, very well tested!

@alessandratrapani How does it look to you?

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #253 (2d4a19b) into main (8884c93) will increase coverage by 1.41%.
Report is 1 commits behind head on main.
The diff coverage is 99.49%.

❗ Current head 2d4a19b differs from pull request most recent head 51fe69e. Consider uploading reports for the commit 51fe69e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   77.55%   78.96%   +1.41%     
==========================================
  Files          38       39       +1     
  Lines        2793     2985     +192     
==========================================
+ Hits         2166     2357     +191     
- Misses        627      628       +1     
Flag Coverage Δ
unittests 78.96% <99.49%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/roiextractors/extractorlist.py 100.00% <ø> (ø)
...ctors/extractors/tiffimagingextractors/__init__.py 100.00% <100.00%> (ø)
...ctors/tiffimagingextractors/scanimagetiff_utils.py 100.00% <100.00%> (ø)
...imagingextractors/scanimagetiffimagingextractor.py 98.96% <99.29%> (+0.69%) ⬆️

Copy link
Collaborator

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, we were discussing about it just few minutes ago and I think this should work properly!

@pauladkisson pauladkisson merged commit 80ecc1f into main Oct 26, 2023
15 checks passed
@pauladkisson pauladkisson deleted the 3DScanImage_rebased branch October 26, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Multi-channel and Multi-plane support for ScanImage
3 participants