-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Plane and Multi-Channel Support for ScanImage #253
Conversation
The one thing that I never really figured out is how to deal with the times for the volumetric imaging. Still not really sure how that should be represented. Right now the times are accessible in each SinglePlaneImagingExtractor. Other than that this should be good to go. |
It looks like our base classes themselves still need to be updated to the latest SI standard ( I know we talked about having an array of times to indicate the shifts for each plane, but for consistency with the other methods like Then we can talk about a separate method for volumes that returns a more detailed structure and get feedback from the rest of the team on that |
This LGTM, very well tested! @alessandratrapani How does it look to you? |
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 77.55% 78.96% +1.41%
==========================================
Files 38 39 +1
Lines 2793 2985 +192
==========================================
+ Hits 2166 2357 +191
- Misses 627 628 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, we were discussing about it just few minutes ago and I think this should work properly!
Fixes #240
Continues from #241 rebased from #248