Fixed Github Workflows #251
Conversation
|
@CodyCBakerPhD, FYI one can run a workflow based on the conclusion of another workflow without invoking complicated meta-workflows (see here. But, since just updating the awscli version fixed the issue, I don't think we need to even make that change. |
Cool, thanks for that - good to know they added that capability |
| pull_request: | ||
| workflow_dispatch: | ||
| workflow_run: | ||
| workflows: [update-testing-data] | ||
| types: [completed] |
There was a problem hiding this comment.
If going this route, you'll probably want to add the 'on success' logic to allow early exit (otherwise will proceed to run tests and fail when it doesn't find a certain file/folder); I wonder if success is an allowed type for the trigger itself?
There was a problem hiding this comment.
Yeah that seems reasonable. Apparently on: workflow_run only works on the default branch (see Issue), so I can't test it before merging? Kind of annoying.
There was a problem hiding this comment.
Yeah that seems reasonable. Apparently on: workflow_run only works on the default branch (see Issue), so I can't test it before merging? Kind of annoying.
This kind of thing is typical of GitHub Action devops stuff - it's the one situation where committing to main to debug stuff is OK IMO
I'll approve and merge this and let you continue messing with it
Updated AWSCLI version to fix github workflows.