Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Minian Segmention Interface #7

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Add Minian Segmention Interface #7

merged 5 commits into from
Oct 22, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Oct 9, 2024 •
edited
Loading

Add Minian Segmention Interface.

TODO:

example nwbfile

@alessandratrapani alessandratrapani mentioned this pull request Oct 9, 2024
Open
28 tasks
@alessandratrapani alessandratrapani mentioned this pull request Oct 21, 2024
Merged
@alessandratrapani alessandratrapani marked this pull request as ready for review October 22, 2024 11:30
h-mayorquin
h-mayorquin approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This will be tested thoroughly as we convert and then we can come back to roiextractor and neuroconv integration later in the game once we setup the testing data on gin/s3.

src/cai_lab_to_nwb/zaki_2024/zaki_2024_metadata.yaml
@@ -11,7 +11,7 @@ NWBFile:
- stress
- PTSD
related_publications:
https://doi.org/### or link to APA or MLA citation of the publication
- https://www.biorxiv.org/content/10.1101/2023.03.13.532469v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@alessandratrapani alessandratrapani merged commit 0ede18b into main Oct 22, 2024
@alessandratrapani alessandratrapani deleted the add_minian_segmentation branch October 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandratrapani @h-mayorquin