-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for continents and their structure #176
base: master
Are you sure you want to change the base?
Conversation
toadle
commented
May 13, 2015
- continents and sub-continents
- Only EN and DE are currently supported locales
A few thoughts I wanted to ask about / bring up:
|
|
@ecbypi I'm happy to change some things, if this functionality is wanted in carmen. Like moving data to YAML and doing some refactoring. Any feedback from you? |
Sorry @toadle, it's been a hectic week. If converting to YAML is possible, that would be great. Additionally, if the Regarding the nesting, I think it might be confusing to have two representations of the world via I'm all for adding this functionality to the gem and thanks for taking the time to work on it and submit a PR. |
I just converted the JSON data to YML, as suggested and removed the world-representation from the regular Continent-API. I would love to have the world only available through The used source-data btw has recently been made available through a Github-project: https://github.com/unicode-cldr/cldr-core/tree/master/ . Could indeed server as a Is the plan the somehow merge this before changing the data-structure or what would be the plan? |
@ecbypi Do we want to continue this somehow? |
I do! My schedule with work has been very full for a while now. I'll squeeze in some time this weekend. |
Does someone want to try to rebase and merge dpaluy#1 ? |
Wow this thing still lives 😇 |