Auto-Sync reproducability + ARM update #2532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Auto-Sync-files
- Enables the Differ to write to the newly translated or the old file. - Adds a patching test. - Allows to predefine user input. - Some simplifications.
This also updates most code to the latest Auto-Sync structure. - Enums are upper case. - Decoders (NULL) are passed to decode_instruction.
Table is sorted in reverse for LLVM 18
For now overlapping patches overwrite each other. It requires a proper conflict handling in the future.
Rot127
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Changes:
Differ
ARM
This also updates the ARM module because the Differ had to be updated for it step by step anyways.
static inlineand adds a new supplementary field.mayLoad/mayStore. This is needed because ARM definitions are not super precise and mix up some input and output operands. With the addition in theARMMapping.cit will set this property always according tomayLoad/mayStoreif it differs (and hence indicates an incorrect definition). The proper way to fix it is to fix thetdfiles. But they are pretty complex and it takes substantially more time.Test plan
All green and added for the Differ.
Closing issues
...