Update libcyaml dependency in cstest to 1.4.2 #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.4.2 contains a fix to replace static_assert calls by a more portable variant. This is relevant for building on e.g. Mac OS X 10.5.
Rot127
approved these changes
Oct 14, 2024
strndup usage, opened an issue: #2517 |
|
@kabeor and this one |
Alright. Thanks for the issue! I didn't make it portable (also not for Windows) because it took too much time already. And with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
1.4.2 contains a fix to replace static_assert calls by a more portable variant. This is relevant for building on e.g. Mac OS X 10.5.
Test plan
Build with MacPorts gcc 7.5.0 on Mac OS X 10.5 and
-DCAPSTONE_BUILD_CSTEST=1. (Hint: there are other issues in the cstest code, but those can be addressed separately)