-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting environment issues #213
Conversation
Just went briefly through the changes, and I noticed we don't have a I just wanted to confirm whether this is indeed the case or there is a different reason why we are going to a manual matching. |
I thought about this and decided it would probably make more sense for environment issues to be across architectures. So you are right. For instance, a broken machine is broken regardless of the architecture. |
5b7d69c
to
dbaf6a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this work, just left a few small style comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe make the TestCaseIsueePreloader a generic ReportedIssuesPreloader
that will watch for both providers, it seems like we are repeating most of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspired by this comment, I refactored most loading of providers into two widgets: NonBlockingProviderPreloader
and BlockingProviderRreloader
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can you not love a code clean-up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick follow-up, excited to see this in use!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think we might be breaking the event log expandable
return Expandable( | ||
title: const Text('Event Log'), | ||
initiallyExpanded: initiallyExpanded, | ||
children: <Widget>[ | ||
testEvents.when( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we deleting the Expandable here, I don't see it anywhere in the new code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried manually testing everything now, so hopefully I didn't miss anything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now we are in a good state to deploy this functionality
Description
Adds ability to report environment issues.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-353
Documentation
Web service API changes
Adds new endpoint
/v1/environments/reported-issues
with GET, POST, PUT, and DELETE.Tests
Added automated tests to the backend.
Manually tested the front-end. See video below:
Screencast from 2024-09-17 14-05-03.webm