Add "current-since" field to services API and CLI #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows as follows in the CLI: $ pebble services Service Startup Current Start Time test2 enabled active today at 17:08 NZST $ pebble services --abs-time Service Startup Current Start Time test2 enabled active 2022-04-28T17:08:45+12:00
hpidcock
approved these changes
Aug 15, 2022
|
Per discussion at London mini-sprint, we want to make the API field |
benhoyt
changed the title
niemeyer
approved these changes
Dec 5, 2022
| Name string `json:"name"` | ||
| Startup string `json:"startup"` | ||
| Current string `json:"current"` | ||
| CurrentSince *time.Time `json:"current-since,omitempty"` // pointer as omitempty doesn't work with time.Time directly |
There was a problem hiding this comment.
That's awkward, considering times have IsZero which fits properly with the notion of omitempty.
This is an internal detail, so I'm not blocking on it, but it's curious that the standard json package is misbehaving there.
| oldStatus := stateToStatus(s.state) | ||
| newStatus := stateToStatus(state) | ||
| if oldStatus != newStatus { | ||
| s.currentSince = time.Now() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
current-sincefield to the API, meaning the time at which the "current" field last changed, for example started (current changed frominactivetoactive), and so on. It's related to #104 (though in a previous iteration it was "start time", not "curren since").Here's how it looks like the CLI:
This PR also removes the "restarts" field which isn't being used and was internal-only. Per #104, we're going to use changes/tasks or events instead.