Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template variable usage #199

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix template variable usage #199

merged 3 commits into from
Nov 20, 2024
+24 −18

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Oct 29, 2024 •
edited
Loading

Issue

In #147 a regression was introduced: template variables were used without $.

Solution

  • Add missing $.
  • Drive-by fixes:
    • Move individual alert rules under groups, as a prep step towards linting with promtool.

Fixes #198.

Relevant context

@sed-i sed-i mentioned this pull request Oct 29, 2024
Draft
@sed-i sed-i marked this pull request as ready for review October 29, 2024 23:33
@sed-i sed-i requested a review from a team as a code owner October 29, 2024 23:33
@lucabello lucabello merged commit 2eecc8f into main Nov 20, 2024
13 checks passed
@lucabello lucabello deleted the sed-i-patch-1 branch November 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkay mmkay mmkay approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
3 participants
@sed-i @mmkay @lucabello