Add upgrade charm on refresh_events to COSAgent #151
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common to have new prometheus alert rules when upgrading a charm. Without refreshing on this event by default, charm authors can easily forget to pass this event manually and the new rules won't be applied.
Signed-off-by: Luca Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Not passing to refresh relations data on charm upgrade will not update Prometheus alert rules.
Solution
Add to refresh on charm upgrade by default.
Context
It's common to have new prometheus alert rules when upgrading a charm. Without refreshing on this event by default, charm authors can easily forget to pass this event manually and the new rules won't be applied.