-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend hierarchy calculation for deeply nested pages #250
base: main
Are you sure you want to change the base?
Conversation
/canonical/self-hosted-runners/run-workflows 1d27df7 |
Lint checks failed for 1d27df7
/home/ubuntu/github-runner/_work/discourse-gatekeeper/discourse-gatekeeper/tests/unit/test_index_contents_hierarchy.py:282:19: W291 trailing whitespace
|
Unit tests failed for 1d27df7
============================= test session starts ============================== tests/unit/action/test_other_actions.py::test__create_directory[dry run mode enabled] PASSED =================================== FAILURES =================================== -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
|
Test coverage for 1d27df7
Static code analysis report
|
It also looks like there have been changed to the discourse change, the ad admin user is no longer there (required for testing), it is now create user ands then promote user. Would you like to fix that? |
Overview
A small change to the calculation of page hierarchy to account for navigation tables with large jumps in nesting.
Previously, the difference in whitespace only got evaluated once, which only accounts for cases where the next item is nested one level higher or lower - but not more.
Rationale
This change is needed because the action fails on documentation sets with hierarchy jumps greater than 1. More context + examples in issue #249.
Module Changes
None
Checklist
src-docs
urgent
,trivial
,complex
)