Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign commits #184

Merged
merged 25 commits into from
Jul 7, 2023
Merged

Sign commits #184

merged 25 commits into from
Jul 7, 2023

Conversation

jdkandersson
Copy link
Contributor

Makes commits signed when required by a given repository.

This requires an e2e tests, they are still being worked on in #183. In the meantime, a successful run is available here: canonical/wordpress-k8s-operator#96

@jdkandersson
add initial function for parsing show status output
ea4206b
@jdkandersson
add tests for parsing git show output
096c3d0
@jdkandersson
fix linting issue
f613555
@jdkandersson
add function that converts files in a commit to PyGithub actions
2a11139
@jdkandersson
add retry if push fails using PyGithub
8e48bc4
@jdkandersson
add branch creation if it doesn't exist
b117fcb
@jdkandersson
retrieve git tag
eb9bfa2
@jdkandersson
deliberately raise error
6de622a
@jdkandersson
ensure the branch exists before pushing changes
64018cc
@jdkandersson
only handle added files
4f2ccb4
@jdkandersson
add in a file
0c55d15
@jdkandersson
switch to creating a git tree
c179024
@jdkandersson
add commit to branch
31df743
@jdkandersson
working implementation
3df0585
@jdkandersson
add tests for using the GitHub client to create a commit
4f2aa23
@jdkandersson
add tests for _commit_file_to_tree_element
cc09e73
@jdkandersson
resolve linting problems
5a99bcf
@jdkandersson
add tests for using GitHub API to push commits
002546c
@jdkandersson
merge main
c27b267
@jdkandersson
small fixes
5899659
@jdkandersson
fix linting issues
5f6542a
@jdkandersson jdkandersson marked this pull request as ready for review July 6, 2023 06:57
@jdkandersson jdkandersson requested a review from a team as a code owner July 6, 2023 06:57
gregory-schiano
gregory-schiano reviewed Jul 6, 2023
View reviewed changes
src/repository.py Show resolved Hide resolved
src/repository.py Outdated Show resolved Hide resolved
src/commit.py Outdated Show resolved Hide resolved
tests/unit/test_repository.py Outdated Show resolved Hide resolved
tests/unit/test_repository.py Outdated Show resolved Hide resolved
tests/unit/test_repository.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Test coverage for cc256cf

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              62      0     22      0   100%
src/action.py               154      0     46      0   100%
src/check.py                 53      0     21      0   100%
src/clients.py               12      0      0      0   100%
src/commit.py                42      0     12      0   100%
src/constants.py              7      0      0      0   100%
src/content.py               50      0     10      0   100%
src/discourse.py            156      0     34      0   100%
src/docs_directory.py        33      0      8      0   100%
src/download.py              23      0      2      0   100%
src/exceptions.py            14      0      0      0   100%
src/index.py                 28      0      6      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py             87      0     27      0   100%
src/navigation_table.py      63      0     20      0   100%
src/reconcile.py             85      0     40      0   100%
src/repository.py           268      0     82      0   100%
src/types_.py               125      0     22      0   100%
---------------------------------------------------------------------
TOTAL                      1290      0    364      0   100%

Static code analysis report

Run started:2023-07-06 15:11:44.781759

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 11618
  Total lines skipped (#nosec): 14
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

gregory-schiano
gregory-schiano approved these changes Jul 6, 2023
View reviewed changes
Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanksyoon
yanksyoon approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdkandersson jdkandersson merged commit c00f929 into main Jul 7, 2023
@jdkandersson jdkandersson deleted the sign-commits branch July 7, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturo-seijas arturo-seijas arturo-seijas left review comments

@gregory-schiano gregory-schiano gregory-schiano approved these changes

@yanksyoon yanksyoon yanksyoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdkandersson @yanksyoon @arturo-seijas @gregory-schiano