Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions for tests and release #13

Closed
wants to merge 2 commits into from

Conversation

sudeephb
Copy link
Contributor

@sudeephb sudeephb commented Dec 7, 2023

Add actions from bootstack-charms-spec

@rgildein
Copy link
Contributor

rgildein commented Dec 8, 2023

You need to configure the repo to use our actions, since no actions were triggered.
I also could not set project or reviewers, will this be fixed with code owners? I think not, and we need to add our groups manually.

@sudeephb
Copy link
Contributor Author

sudeephb commented Dec 8, 2023

I have manually added the maintainers and admin permissions for the relevant teams.

Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci needs to be enabled first.

Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin needs to add JIRA_URL to Github secrets and set up sonar project to enable those integrations

# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

# These owners will be the default owners for everything in the repo. Unless a
# later match takes precedence, @canonical/bootstack will be requested for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated as well

Suggested change
# later match takes precedence, @canonical/bootstack will be requested for
# later match takes precedence, @canonical/soleng-reviewers will be requested for

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIRA_URL is there.

@jneo8
Copy link
Contributor

jneo8 commented Dec 13, 2023

Please move the discussion to #15 , the checks is running there.

@jneo8 jneo8 closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants