Update AKS and EKS action to properly run on schedule #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvlassis
changed the title
orfeas-k
reviewed
Nov 15, 2024
| echo "bundle_versions=${bundle_versions}" >> $GITHUB_OUTPUT | ||
| if [[ "${{ github.event_name }}" == "schedule" ]]; then | ||
| bundle_versions=$(yq '. | keys' .github/dependencies.yaml -o=json | tr -d '\n') | ||
| echo "bundle_versions=${bundle_versions}" |
There was a problem hiding this comment.
It's not clear to me why we need this line
There was a problem hiding this comment.
The "echo" is only for displaying the bundle_versions on the output of the action on Github, see here. Do you think it's best to remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1124.
This PR updates the
deploy-to-aks.yamlanddeploy-to-eks.yamlfiles to properly run on schedule.The current issue that we had to overcome is explained here
To fix this issue, I have condensed the 2 jobs into 1 job that always run, and the
ifstatements are located inside runNote that there is an issue when writing multiline strings to $GITHUB_OUTPUT, and that's why we run
trto remove all newline characters from the JSON output ofyq.