Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the notes for the retrieve POST calls #372

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RandyLevensalor
Copy link
Collaborator

Fixes issues Add explanation on why there is a "POST /retrieve-sessions" instead of GET #359

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Clarifies why a POST call is used of a GET to retrieve data from the QoD APIs.

Which issue(s) this PR fixes:

Fixes #359

Special notes for reviewers:

Changelog input

Added notes to retrieve POST calls to explain why these are a POST instead of a GET.

Additional documentation

This section can be blank.

docs

Fixes issues Add explanation on why there is a "POST /retrieve-sessions" instead of GET camaraproject#359
code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved
code/API_definitions/qos-profiles.yaml Outdated Show resolved Hide resolved
code/API_definitions/quality-on-demand.yaml Outdated Show resolved Hide resolved
hdamker
hdamker previously approved these changes Oct 16, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to incorporate the hyperlink to the text

code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved
code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved
Adding link into flow of text

Co-authored-by: Jose Luis Urien <[email protected]>
Moved link, no longer needed here.

Co-authored-by: Jose Luis Urien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explanation on why there is a "POST /retrieve-sessions" instead of GET
3 participants