-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the notes for the retrieve POST calls #372
Open
RandyLevensalor
wants to merge
7
commits into
camaraproject:main
Choose a base branch
from
cablelabs:feat/retrieve-post-note
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updating the notes for the retrieve POST calls #372
RandyLevensalor
wants to merge
7
commits into
camaraproject:main
from
cablelabs:feat/retrieve-post-note
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues Add explanation on why there is a "POST /retrieve-sessions" instead of GET camaraproject#359
RandyLevensalor
requested review from
hdamker,
eric-murray and
jlurien
as code owners
October 9, 2024 16:40
hdamker
reviewed
Oct 14, 2024
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
hdamker
previously approved these changes
Oct 16, 2024
jlurien
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions to incorporate the hyperlink to the text
Adding link into flow of text Co-authored-by: Jose Luis Urien <[email protected]>
Moved link, no longer needed here. Co-authored-by: Jose Luis Urien <[email protected]>
jlurien
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues Add explanation on why there is a "POST /retrieve-sessions" instead of GET #359
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Clarifies why a POST call is used of a GET to retrieve data from the QoD APIs.
Which issue(s) this PR fixes:
Fixes #359
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.