Add QoS Profile User Story #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhepworth
requested review from
hdamker,
eric-murray,
RandyLevensalor and
jlurien
as code owners
RandyLevensalor
previously approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks for doing this @benhepworth
I approve. Since I helped a little, others need to chime in as well :)
…with Commonalities
|
@benhepworth within the last QoD call we discussed some changes, if I remember in the section "Activities/Steps", which you agreed to make. Do you still plan to add them? Beyond that the PR LGTM. Would be good to start here the final review asap. |
|
@hdamker - yes, I added those changes on Friday and updated the PR. The changes specifically were:
From my notes those were all the needed changes - was there anything else that needs updating? I think we can move this to final review now. |
hdamker
approved these changes
Oct 15, 2024
eric-murray
approved these changes
Oct 15, 2024
RandyLevensalor
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add Qos Profile User Story. Required for full release.
Which issue(s) this PR fixes:
Fixes #341
Special notes for reviewers:
Made a few formatting and text changes that are different than the QoD user story (i.e. some extra spacing to make it more readable). Should we update the QoD User Story also to align?
Changelog input
Additional documentation
This section can be blank.