-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PR for public release r1.2 (M4) #353
Conversation
Target state for M4 assumed
Release notes for r1.2 including: Editorial changes or some entries from r1.1 Added PR #335 which was missed to be mentioned in r1.1
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
…hub.com/camaraproject/QualityOnDemand into 352-create-pr-for-public-release-r12-m4
Rebase with main
…hub.com/camaraproject/QualityOnDemand into 352-create-pr-for-public-release-r12-m4
added PR #356
Added #356 proactively to CHANGELOG and updated the PR description. |
Clarification of "optional device object" within SessionInfo Description to address issue #340
All PRs for v0.11.0 so far closed, adding @camaraproject/release-management_maintainers as reviewer. |
@jlurien @RandyLevensalor @eric-murray @tlohmar: I've addressed #340 here with e7bd701. Please have a look if that is ok for you. |
I do not see the updated User Story file in this PR, but I have a comment on the Summary section: I would propose to drop the "from a Communication Service Provider (CSP)" as the app can also talk to an Aggregator. Also suggest to drop the word "our" from "our end users". |
I think you can remove the LICENCE.APACHE.2.0 file from the code/Test_definitions folder as it is already present in the main folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M4 release management review done: A few minor comments only
please check and then LGTM
documentation/API_documentation/quality-on-demand-API-Readiness-Checklist.md
Show resolved
Hide resolved
documentation/API_documentation/quality-on-demand-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
@tanjadegroot Thanks a lot for the intensive review. See my answer on your comments. Please have a view if ok for you. I have also deleted the duplicated license file (I recently added the file at the right place but have overseen that there was one in /code). For the User Story I don't see the changes as urgent and have kept it untouched (but I merged @eric-murray @jlurien @RandyLevensalor please check the latest changes and approve the PR if ok for you. |
@jlurien @eric-murray @RandyLevensalor I've addressed all review comments from Tanja, so from Release Management there is green light. But I can't merge the release PR without a Codeowner review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hdamker thanks for all of the updates and work on this!!
Review done by RM: LGTM |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Create the public release r1.2, see #352
These PRs have to be merged before the release PR!
Which issue(s) this PR fixes:
Fixes #352
Special notes for reviewers:
Changelog input