-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Release for Fall24 meta-release #81
Conversation
Change version to v1
Update checklist to r1.2
update readme for r1.2
Updated for r1.2
Align sentences with template
update changelog for completion
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Co-authored-by: Herbert Damker <[email protected]>
Line 1 of the feature file is |
documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Update version to v1.0.0 in line 1
documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Fixed ! Thanks |
…iness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
Please replace the text underneath the Readiness checklist table with the latest version from https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md As also mentioned in camaraproject/Commonalities#266 (comment) |
…iness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
So far what I've seen, rest LGTM. Please add @camaraproject/release-management_maintainers as reviewer to trigger the official review by Release Management and remove me as reviewer. |
Thanks a lot for Herbert for the very helpful review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigludo7 @fernandopradocabrillo Could you please check if the comment in camaraproject/IdentityAndConsentManagement#189 (comment) is relevant for the API spec? |
For me, and understood that @jpengar has same conclusion, the 403 INVALID_TOKEN_CONTEXT error is not relevant for the OTP validation API as if the phone number is in the token the API is useless. Indeed this API UC is to be use when we cannot detect the phone number by ourselves. But perhaps i miss something. |
All good for me, I just wanted to be sure that the conclusion of @jpenpar is shared here. |
Male linting happy
.feature file - change of 36 lines needed: |
Change all path from /v0/ to /v1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist needs small updates & and a TSC decision about the missing prerequisite (which then can be added as comment).
documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…iness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
…iness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
Remove empty lines
Taking care of the Test result statement accordingly to camaraproject/ReleaseManagement#89
@hdamker Managed the test statement in the checklist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on behalf of @camaraproject/release-management_maintainers. Let's create the release.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Related to #58
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
In the changelog I've added the elements from the v0.5.0 that were missing.
Missing link for Test Statement
Changelog input
Additional documentation
This section can be blank.