-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geofencing: Alignment of errors with Commonalities #223
geofencing: Alignment of errors with Commonalities #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reconsider adding explicit mention to errors such as 405, 406, 409, 410, 412, 415, 429, which are not part of the core of the API logic, and may be implemented by previous layers (access control, etc). This has been also discussed in QOD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I try to be consistent :) :) same comments that for Device Status subscription API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max
Look good for me.
@akoshunyadi @jlurien @bigludo7 same discussion here like in camaraproject/DeviceStatus#193 (comment) We need now a clear decission: Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. IMO we should restrict the codes to the relevant ones for the spec, but the specific list should be discussed in Commonalities and the guidelines and artifacts be adjusted.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Alignement of errors according to Commonalities guideline.
Which issue(s) this PR fixes:
Fixes #222
Changelog input