Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 styling #105

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

abhinab-choudhury
Copy link

Recording.2024-06-16.133803.mp4

The Error was because of Google Adds.

@Amark19
Copy link
Collaborator

Amark19 commented Jun 16, 2024

Thanks for your contribution !! @abhinab-choudhury .
Reviewing it .

@Amark19
Copy link
Collaborator

Amark19 commented Jun 16, 2024

image
Can see there is still a some margin left from bottom

@Amark19 Amark19 self-requested a review June 16, 2024 10:34
@Amark19 Amark19 linked an issue Jun 16, 2024 that may be closed by this pull request
@Amark19
Copy link
Collaborator

Amark19 commented Jun 17, 2024

@abhinab-choudhury can u also resolve other changes that I have suggested

@abhinab-choudhury
Copy link
Author

abhinab-choudhury commented Jun 19, 2024

sorry, but what were you suggestions sir

mysite/templates/main_index.html Outdated Show resolved Hide resolved
staticfiles/css/main.css Show resolved Hide resolved
@Amark19
Copy link
Collaborator

Amark19 commented Jun 19, 2024

sorry, but what were you suggestions sir

Can u check now I forgot to submit it ... it was in pending state
image

@abhinab-choudhury
Copy link
Author

Is it Good Now

@abhinab-choudhury
Copy link
Author

Hi, just a humble remainder

staticfiles/css/main.css Show resolved Hide resolved
staticfiles/admin/css/base.css Show resolved Hide resolved
mysite/templates/main_index.html Show resolved Hide resolved
@Amark19
Copy link
Collaborator

Amark19 commented Jun 23, 2024

@abhinab-choudhury can u check now ?
Actually got busy with other stuff ..

@abhinab-choudhury
Copy link
Author

sure

@abhinab-choudhury
Copy link
Author

if you don't mind can use linting tool like Black, ESLinter and HTMLHint or any-others for formations the code or explore pre-commit hooks to automatically check before commits using the pre-commit library

@Amark19
Copy link
Collaborator

Amark19 commented Jun 23, 2024

if you don't mind can use linting tool like Black, ESLinter and HTMLHint or any-others for formations the code or explore pre-commit hooks to automatically check before commits using the pre-commit library

Yeah u r correct but as this is django + vanilla html,css,js project it would be so difficult to integrate such things but ofcourse not impossible . I am telling u to discard unwanted formatting changes because its good practice that u do not edit core file or lines unless its too necessary.

And yes I am aware of this and I have integrate similar things in my other react projects one of that is Whiteboard . If u are interested u can contribute in that as well as it is open source too .

@abhinab-choudhury
Copy link
Author

image

@abhinab-choudhury
Copy link
Author

and about Whiteboard was going throught that as well, I will surely add valuable contiributaion into that..

padding: 15px;
margin: auto;
display: flex;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is just work around not a generic solution as this problem persists with sign up page as well. we need to write some css logic to footer itself.
image

@Amark19
Copy link
Collaborator

Amark19 commented Jun 23, 2024

@abhinab-choudhury lets ignore the rest changes I guess this is due to how linux(github) and windows handles end-of line as there are different ways to handle and each OS has their own default settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer padding issue
2 participants