-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #21 styling #105
base: master
Are you sure you want to change the base?
Fix #21 styling #105
Conversation
Thanks for your contribution !! @abhinab-choudhury . |
c95208a
to
72485a2
Compare
@abhinab-choudhury can u also resolve other changes that I have suggested |
sorry, but what were you suggestions sir |
Is it Good Now |
Hi, just a humble remainder |
@abhinab-choudhury can u check now ? |
sure |
if you don't mind can use linting tool like Black, ESLinter and HTMLHint or any-others for formations the code or explore pre-commit hooks to automatically check before commits using the pre-commit library |
Yeah u r correct but as this is django + vanilla html,css,js project it would be so difficult to integrate such things but ofcourse not impossible . I am telling u to discard unwanted formatting changes because its good practice that u do not edit core file or lines unless its too necessary. And yes I am aware of this and I have integrate similar things in my other react projects one of that is Whiteboard . If u are interested u can contribute in that as well as it is open source too . |
and about Whiteboard was going throught that as well, I will surely add valuable contiributaion into that.. |
padding: 15px; | ||
margin: auto; | ||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinab-choudhury lets ignore the rest changes I guess this is due to how linux(github) and windows handles end-of line as there are different ways to handle and each OS has their own default settings. |
Recording.2024-06-16.133803.mp4
The Error was because of Google Adds.