Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjustments to CI caching #5495

Merged
merged 3 commits into from
Apr 15, 2023
Merged

chore: Adjustments to CI caching #5495

merged 3 commits into from
Apr 15, 2023

Conversation

francislavoie
Copy link
Member

No description provided.

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Apr 15, 2023
@francislavoie francislavoie added this to the v2.7.0 milestone Apr 15, 2023
@mohammed90
Copy link
Member

I think we need actions/setup-go#366, otherwise the cache gets clobbered by the multiple runners, no?

@francislavoie
Copy link
Member Author

francislavoie commented Apr 15, 2023 •
edited
Loading

I don't think so. I looked at the source, and their cache key is OS name + Go version + go.sum. We would only need that if we used different OS versions I think.

Also checked which cache paths it uses, and it runs go env GOMODCACHE and go env GOCACHE which covers the paths we already had defined (except it's better than what we did because it properly gets the platform specific path correctly without hardcoding)

@mohammed90
Copy link
Member

Ok, cool!

mohammed90
mohammed90 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, Francis!

@francislavoie francislavoie merged commit 998c6e0 into master Apr 15, 2023
@francislavoie francislavoie deleted the ci-cache branch April 15, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

Assignees
No one assigned
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mohammed90