Dashboard Api Controller: call UpdateComponentCommand only with modified params #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
reviewed
Jun 24, 2024
Comment on lines
+41
to
+49
| null, | ||
| null, | ||
| Binput::get('status'), | ||
| $component->link, | ||
| $component->order, | ||
| $component->group_id, | ||
| $component->enabled, | ||
| $component->meta, | ||
| $component->tags, | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| null, |
There was a problem hiding this comment.
This definitely doesn't look right to me...
There was a problem hiding this comment.
Hum.. that's the same logic implemented anywhere else? Example from ./app/Bus/Handlers/Commands/Incident/CreateIncidentCommandHandler.php:
// Update the component.
if ($component = Component::find($command->component_id)) {
execute(new UpdateComponentCommand(
Component::find($command->component_id),
null,
null,
$command->component_status,
null,
null,
null,
null,
null,
null,
true // Silent mode
));
To see the problem, try updating a component with no flag in the dashboard multiple times, and have a look to flags in DB after each update.
Pierre
There was a problem hiding this comment.
To see the problem, try updating a component with no flag in the dashboard multiple times, and have a look to flags in DB after each update.
I mean: with my PR's merged last week. They broke components updates from the gui. The current PR fix them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #4402, changing a component state with no tags creates a tag "[]" in DB (an empty array to string).
Fix: calls to UpdateComponentCommand from dash controller should be done only on modified params, as it is done on incident creation/updates.