New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose s.request as s.RequestRaw so one can send JSON directly #1560

Open

ldemailly wants to merge 1 commit into bwmarrin:master from ldemailly:expose_raw_request

ldemailly commented Aug 23, 2024 •

edited

Loading

Otherwise you need to either artificially make a map[string]any from the json or duplicate

	if bucketID == "" {
		bucketID = strings.SplitN(urlStr, "?", 2)[0]
	}
	return s.RequestWithLockedBucket(method, urlStr, contentType, b, s.Ratelimiter.LockBucket(bucketID), sequence, options...)

and I think the details of the rate limit/locking logic should stay hidden rather than duplicated in caller code


          Expose s.request as s.RequestRaw so one can send JSON directly

a25990f

FedorLap2006 approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet