-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/continue seeding after closing player #607
base: master
Are you sure you want to change the base?
Feature/continue seeding after closing player #607
Conversation
'autoSeed' - starts up a forked process with a WebTorrent client which enables this feature. Torrent files are create and saved in tmp folder to be used later for seeding. Randomly selects files for join swarm. 'seedLimit' - starting limit for number of torrents connected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heads up this is a very important patch for us so it might be a bit of time in review =)
it looks like it's missing the 'named seeder' thing we talked about.
also, we probably want to hook this up into the torrent updater code too
still has a lot of whitespace changes.
<!-- Global variables --> | ||
<script src="global.js"></script> | ||
<!-- Global variables --> | ||
<script src="global.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still has whitespace issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you guys using tabs or spaces here? jshint doesn't seem to lint for me..
@@ -84,32 +85,32 @@ | |||
<script src="lib/models/lang.js"></script> | |||
<script src="lib/models/content_item.js"></script> | |||
<script src="lib/models/movie.js"></script> | |||
<script src="lib/models/show.js"></script> | |||
<script src="lib/models/show.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still has whitespace issues
<script src="lib/models/generic_collection.js"></script> | ||
<script src="lib/models/movie_collection.js"></script> | ||
<script src="lib/models/stream_info.js"></script> | ||
<script src="lib/models/show_collection.js"></script> | ||
<script src="lib/models/anime_collection.js"></script> | ||
<script src="lib/models/anime_collection.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still has whitespace issues
<script src="lib/models/indie_collection.js"></script> | ||
<script src="lib/models/favorite_collection.js"></script> | ||
<script src="lib/models/watchlist_collection.js"></script> | ||
<script src="lib/models/watchlist_collection.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still has whitespace issues
src/app/lib/views/main_window.js
Outdated
|
||
// Focus the window when the app opens | ||
win.focus(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps will add back.
getTorrentFiles: function() { | ||
if (this.torrentFiles === null) { | ||
var regexp = /\.torrent$/i; | ||
var files = fs.readdirSync(this.torrentDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of calling fs here, i think i'd rather maintain a registery of things that have been 'added/removed' to this module.
seedLimit: Settings.seedLimit | ||
}); | ||
|
||
this.worker = child.fork(taskFile, [args], {silent: true, execPath:'node'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'node' will fail on machines that don't have nodejs installed (we bundle)
@xaiki: yup no worries about the time it'll take. I got other PRs bug/suggestions to make :) |
hey any news on this ? |
Uses a forked process with WebTorrent client and saved torrents in cache tmp directory to accomplish this.