-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed All day events start time may be incorrect (iOS only) #337 #450
Conversation
Fixed fullDay with DateRange events creation (not only one fullday events possible to create) Timezone should be set only if event is not full day
Could you please describe what exactly this PR fixes. It looks like this PR also introduces all-day-multi-day events. Is that correct? |
I just tested your changes on iOS. Could you please also change the example app, so while adding a new event, when toggling all-day to on, the input field of event end no longer disappears. |
My PR fixed the problem with creating all-day-multi-day events in IOS. Yep I can fix test app as well) |
Great, that's what I thought. Is a very welcome change. Perfect if you can change the example app as well, thank you. |
Now that we have multi-day all-day events on both platforms (see builttoroam#450), handling the platforms differently is no longer necessary.
Since I don't want this PR to be blocked any longer, waiting only for changes in the example app, I split it up into a separate PR (see #454). Thanks @OleksandraFedotova for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@IVLIVS-III Sorry for not providing changes to the example app, will do my best next time while contributing ;) |
Fixed fullDay with DateRange events creation (not only one fullday events possible to create) Timezone should be set only if event is not full day