Support cel c++'s 'nan' (#59)

Note that .lowerAscii is an extension function
bufbuild · Jul 21, 2023 · a1c7b6b · a1c7b6b
1 parent 582df81
commit a1c7b6b
Show file tree

Hide file tree

Showing 2 changed files with 1,926 additions and 1,925 deletions.
diff --git a/proto/protovalidate/buf/validate/validate.proto b/proto/protovalidate/buf/validate/validate.proto
@@ -377,7 +377,7 @@ message FloatRules {
   // infinite or NaN, an error message is generated.
   bool finite = 8 [(priv.field).cel = {
     id: "float.finite",
-    expression: "this == 1.0/0.0 || this == -1.0/0.0 || string(this) == 'NaN' ? 'value must be finite' : ''",
+    expression: "this == 1.0/0.0 || this == -1.0/0.0 || string(this) in ['NaN', 'nan'] ? 'value must be finite' : ''",
   }];
 }
 
@@ -568,7 +568,7 @@ message DoubleRules {
   // infinite or NaN, an error message is generated.
   bool finite = 8 [(priv.field).cel = {
     id: "double.finite",
-    expression: "this == 1.0/0.0 || this == -1.0/0.0 || string(this) == 'NaN' ? 'value must be finite' : ''",
+    expression: "this == 1.0/0.0 || this == -1.0/0.0 || string(this) in ['NaN', 'nan'] ? 'value must be finite' : ''",
   }];
 }