DEV-1541-dont-fail-on-empty-images #477
Conversation
Following issues have been fixed in this commit: - SVG top element should not use `getComputedStyle` since it produces invalid CSS in chrome. Instead, just use `style` attribute. - When `xlink:href` is being used in SVG make sure that selectors are properly escaped - Use browser-provided CSS parsing when embedding images and fonts. - Fix a bug in deferred insertion of CSS rules. - Fix a test for svg-use-tag
fix: svg and css parsing
tests: fix tests
Celtra repo
enable test and use master
Don't report errors when there aren't any [DEV-223]
DEV-229 Push to NPMJS
|
@UsajMarko Please provide us with more info about this pull request. |
|
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 62.93% 63.10% +0.17%
==========================================
Files 10 10
Lines 580 580
Branches 143 143
==========================================
+ Hits 365 366 +1
Misses 151 151
+ Partials 64 63 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.