Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP! Use MOJO logging instead of sysout and some docs #37

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

astubbs
Copy link

@astubbs astubbs commented Aug 12, 2020

Attempts to address #8

Implementation as is prints out DEBUG level also, and doesn't appear to routing through the proper logging system as the actual output appears differently to other maven logging statements -

[INFO] Changes detected - recompiling the module!
[INFO] Compiling 26 source files to /Users/antony/repos/confluent/async-consumer/async-consumer-core/target/test-classes
[info] Jabel static initialising ByteBuddy
[info] Jabel ByteBuddy initialisation complete
[debug] Jabel: initialized. Enabled features:
	- LOCAL_VARIABLE_TYPE_INFERENCE
	- DIAMOND_WITH_ANONYMOUS_CLASS_CREATION
	- SWITCH_RULE
	- EFFECTIVELY_FINAL_VARIABLES_IN_TRY_WITH_RESOURCES
	- PRIVATE_SAFE_VARARGS
	- VAR_SYNTAX_IMPLICIT_LAMBDAS
	- TEXT_BLOCKS
	- SWITCH_EXPRESSION
	- SWITCH_MULTIPLE_CASE_LABELS

[INFO] ...

Implementation info from: https://stackoverflow.com/a/22423213/105741

Tried using Slf4j also, and got an unimplemented slf4j subsystem response, so doesn't seem like that's being used...

@astubbs astubbs mentioned this pull request Aug 13, 2020
@bsideup
Copy link
Owner

bsideup commented Aug 16, 2020

Hi @astubbs,

the Java Compiler has its own logging system that one should be used. Sorry for not having time to fix #8 yet, but maybe you would like to explore it more?

@astubbs
Copy link
Author

astubbs commented Aug 17, 2020

Ah! Thanks, I'll check it out..

@astubbs
Copy link
Author

astubbs commented Aug 17, 2020

@bsideup you're not referring to java.util.logging.Logger, are you?

@astubbs astubbs marked this pull request as draft August 17, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants