Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets planning should be compile-kind agnostic #380

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

boozook
Copy link
Owner

@boozook boozook commented Jun 11, 2024

Following #376

  • fix assets-build-planner
  • plan compile-kind agnostic
  • improve build-plan cache, add resolved env vars

To reproduce:

  1. prepare package with
    • lib
    • more then one bins, including main.rs as auto-target
    • some example(s)
  2. run:
    cargo build -p=cargo-playdate && \
    CARGO_PLAYDATE_LOG="trace" RUST_LOG="trace" ./target/debug/cargo-playdate assets -vvv \
    --target-dir=./target-dev-test \
    -p=test-workspace-main-crate \
    --manifest-path=${PREPARED_PACKAGE_FROM_STEP_1}/Cargo.toml \
    --target=thumbv7em-none-eabihf --target=your-host-target \
    -- --examples --bins --lib # or --all-targets

cargo/src/assets/mod.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the cargo About cargo or cargo-playdate label Jun 11, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@boozook boozook added bug Something isn't working assets Assets Build System labels Jun 11, 2024
@boozook boozook enabled auto-merge (squash) June 11, 2024 17:54
@boozook boozook disabled auto-merge June 11, 2024 18:22
@boozook boozook merged commit 7eb4e5a into main Jun 11, 2024
36 checks passed
@boozook boozook deleted the assets-plan-compile-kind-agnostic branch June 11, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Assets Build System bug Something isn't working cargo About cargo or cargo-playdate
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant