Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Darwin PPC32 #215

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

evanmiller
Copy link
Contributor

@evanmiller evanmiller commented Dec 27, 2022

This PR consolidates some of @kernigh's work over in #211. It successfully compiles and runs the Fibonacci test, without a crash, on PPC32 hardware running Darwin 8:

$ ./a.out
0 1 1 2 3 5 8 13 21 34
main: done
$ uname -r
8.11.0

For make_fcontext, use the diff provided here:

#211 (comment)

For ontop_context, adapt the Linux PPC32 fixes from here:

df8fb6b

@barracuda156
Copy link
Contributor

@evanmiller Do you think we should first ensure that fiber does not fail with these changes? Given that is was building before with not fully fixed context, it presumably should build with the properly fixed one.

For make_fcontext, use the diff provided here:

boostorg#211 (comment)

For ontop_context, adapt the Linux PPC32 fixes from here:

boostorg@df8fb6b

Co-authored-by: George Koehler <[email protected]>
@evanmiller
Copy link
Contributor Author

@evanmiller Do you think we should first ensure that fiber does not fail with these changes? Given that is was building before with not fully fixed context, it presumably should build with the properly fixed one.

@barracuda156 Which compilers / Boost versions were successfully building Fiber on PPC? I encountered an issue with GCC7 / Boost 1.81 but I can't comment on any other combinations.

@evanmiller evanmiller marked this pull request as ready for review December 27, 2022 15:55
@barracuda156
Copy link
Contributor

@evanmiller Do you think we should first ensure that fiber does not fail with these changes? Given that is was building before with not fully fixed context, it presumably should build with the properly fixed one.

@barracuda156 Which compilers / Boost versions were successfully building Fiber on PPC? I encountered an issue with GCC7 / Boost 1.81 but I can't comment on any other combinations.

Well, everything was building with my earlier minimal fixes to context (which are not sufficient, as we know now).

@evanmiller
Copy link
Contributor Author

@barracuda156 If you were able to build everything before, why don't you try building Fiber with these proposed changes and report back?

@barracuda156
Copy link
Contributor

@barracuda156 If you were able to build everything before, why don't you try building Fiber with these proposed changes and report back?

@evanmiller I will do it soonish.

@olk olk merged commit 16e2c13 into boostorg:develop Dec 27, 2022
@olk
Copy link
Member

olk commented Dec 27, 2022

ty

@barracuda156
Copy link
Contributor

Now we have ppc64 left to fix. And possibly fiber for both.

evanmiller added a commit to evanmiller/macports-ports that referenced this pull request Dec 28, 2022
@evanmiller evanmiller deleted the darwin-ppc32-fixes branch December 28, 2022 16:38
kencu pushed a commit to macports/macports-ports that referenced this pull request Jan 7, 2023
@barracuda156
Copy link
Contributor

@evanmiller Could you remind, what prevented us from fixing ppc64 along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants