-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Darwin PPC32 #215
Conversation
dabd3cc
to
565c3ae
Compare
@evanmiller Do you think we should first ensure that |
For make_fcontext, use the diff provided here: boostorg#211 (comment) For ontop_context, adapt the Linux PPC32 fixes from here: boostorg@df8fb6b Co-authored-by: George Koehler <[email protected]>
565c3ae
to
070d03f
Compare
@barracuda156 Which compilers / Boost versions were successfully building Fiber on PPC? I encountered an issue with GCC7 / Boost 1.81 but I can't comment on any other combinations. |
Well, everything was building with my earlier minimal fixes to |
@barracuda156 If you were able to build everything before, why don't you try building Fiber with these proposed changes and report back? |
@evanmiller I will do it soonish. |
ty |
Now we have |
@evanmiller Could you remind, what prevented us from fixing |
This PR consolidates some of @kernigh's work over in #211. It successfully compiles and runs the Fibonacci test, without a crash, on PPC32 hardware running Darwin 8:
For
make_fcontext
, use the diff provided here:#211 (comment)
For
ontop_context
, adapt the Linux PPC32 fixes from here:df8fb6b