backfill: use constants for bufferedOp.kind #641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part of #638)
This utilizes constants from the
repomgr
package for buffered operations.This was already the case, actually, as they were used here, I just added them throughout the code.
They're also used to check the operations emitted by the firehose: https://github.com/bluesky-social/indigo/blob/main/backfill/backfill.go#L469-L471
The firehose, in turn, uses the events emitted by the repo manager for the
Action
field in firehose events: https://github.com/bluesky-social/indigo/blob/main/indexer/indexer.go#L83-L94This brings us full circle:
Repo manager emits diff operations -> firehose repo commit ops
.Action
-> backfill buffered op.kind
Notably, the constants are also given in the lexicon: https://github.com/bluesky-social/atproto/blob/main/lexicons/com/atproto/sync/subscribeRepos.json#L178
But
lexgen
does not generate constants for them.The test in
backfill_test.go
is broken, but I changed the constants anyway.