-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf[BMQ,MQB]: do not build tmp functions on ACKs #497
base: main
Are you sure you want to change the base?
Conversation
143ea9b
to
b08163b
Compare
Signed-off-by: Evgeny Malygin <[email protected]>
b08163b
to
b821442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 353 of commit b821442 has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not avoid BuildEventActionFunctor
(and the virtual operator()()
) if we introduce template parameters to ProtocolUtil::buildEvent
(BuildConfirmFunctor
and BuildAckFunctor
)?
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 369 of commit 3d054bc has completed with FAILURE
Should speed up ACK processing path in SESSION dispatcher thread on any broker connected to client and also
bmqtool
in consume mode. Also, removes many millions of allocations with default allocator.Before:
After: