Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf[BMQ,MQB]: do not build tmp functions on ACKs #497

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Nov 2, 2024

Should speed up ACK processing path in SESSION dispatcher thread on any broker connected to client and also bmqtool in consume mode. Also, removes many millions of allocations with default allocator.

Before:
Screenshot 2024-11-02 at 23 37 10

After:
Screenshot 2024-11-03 at 02 41 57

@678098 678098 requested a review from a team as a code owner November 2, 2024 23:46
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 353 of commit b821442 has completed with FAILURE

Copy link
Collaborator

@dorjesinpo dorjesinpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not avoid BuildEventActionFunctor (and the virtual operator()()) if we introduce template parameters to ProtocolUtil::buildEvent (BuildConfirmFunctor and BuildAckFunctor)?

@dorjesinpo dorjesinpo assigned 678098 and unassigned dorjesinpo Nov 4, 2024
@678098 678098 assigned dorjesinpo and unassigned 678098 Nov 13, 2024
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 369 of commit 3d054bc has completed with FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants