Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Log dumper #445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: Log dumper #445

wants to merge 1 commit into from

Conversation

waldgange
Copy link
Collaborator

@waldgange waldgange commented Oct 7, 2024

Introduce a set of parameters for log record dumping by a trigger message. This section can be added to the Broker config:

{
    ....
    "taskConfig": {
        ...
        "logDump": {
            "recordBufferSize": 32768,
            "recordingLevel": "TRACE",
            "triggerLevel": "FATAL"
        }
        ....
    }
    ....
}

Where:
recordBufferSize is a size of default logger's record buffer in bytes.
recordingLevel is the lowest severity level of the record that will be stored by the logger in its log record buffer.
triggerLevel is the lowest severity level of the record that will cause immediate publication of that record and any records in the logger's log record buffer.

@waldgange waldgange requested a review from a team as a code owner October 7, 2024 18:03
@waldgange waldgange changed the title Log dumper Feat: Log dumper Oct 8, 2024
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 294 of commit 004c2fc has completed with FAILURE

@chrisbeard chrisbeard self-assigned this Oct 9, 2024
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 298 of commit 28ec79b has completed with FAILURE

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 300 of commit 8ce4504 has completed with FAILURE

@chrisbeard
Copy link
Contributor

Looks like there's a unit test for the log controller, let's extend that to test this as well.

I think the most important thing to make sure of with this test is that we don't break compatibility with older configs that don't utilize this.

@waldgange waldgange force-pushed the logdumper branch 3 times, most recently from 9a30dd5 to b827d6f Compare October 16, 2024 08:35
@waldgange
Copy link
Collaborator Author

@chrisbeard I've added a unit test for LogControllerConfig::fromObj(), also I've removed the outdated method fromDatum() and its unit test.
In order not to break compatibility with old broker configs we have to release this feature in two steps. As the first step we release the new config, containing the new parameters. When all machines upgrade to this version we will release the broker that retrieves new parameters from the config

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 310 of commit a63f4e7 has completed with FAILURE

@waldgange waldgange force-pushed the logdumper branch 4 times, most recently from 5a0a785 to 7b9f24e Compare November 1, 2024 10:09
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 351 of commit 7b9f24e has completed with FAILURE

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 358 of commit f645c26 has completed with FAILURE

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 360 of commit c3ef08d has completed with FAILURE

Signed-off-by: Anton Pryakhin <[email protected]>
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 372 of commit 6a93d60 has completed with FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants