Fix[mqbs::FileStore]: Do not remove purge record even if app is deleted #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikulimu
changed the title
pniedzielski
approved these changes
Nov 6, 2024
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
kaikulimu
force-pushed
the
keep-purge-record
branch
from
adb42e7
to
f455c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a journal file inconsistency bug if a replica node contains a purge appId record preceding a removal record for that appId, and bounces before rollover. Primary, who rolled over fine, would write that purge record to the new file. Replica, who bounced, would not keep this record in memory during recovery, and thus would not write the record to the new file during rollover. This is because rollover logic decides the set of records to roll over based on the in-memory data structure
d_records. This caused journal file inconsistency between primary and replica, where replica's file offset would be behind due to missing certain purge appId records.The fix is to not skip purge record even if app is deleted, during recovery.