android issue fixed if user denied mic permission and join meeting #652
Conversation
| @@ -461,7 +461,9 @@ public void connectToRoomWrapper( | |||
| this.enableH264Codec = enableH264Codec; | |||
|
|
|||
| // Share your microphone | |||
| if(enableAudio){ | |||
There was a problem hiding this comment.
If I'm understanding this correctly, this means that if the participant joins the call without audio enabled, and subsequently enables it, that things will fail.
I'm wondering if it would make more sense to have a createAudioTrack flag. Either that or ensure that when the enabling is toggled that it creates a local audio track if it doesn't already exist.
There was a problem hiding this comment.
Not it's not the same as you understand .
suppose user not give microphone permission than this extra code was running so we just run this particular code .
and it's working fine
- when user given permission in between and enabled the audio
- And when user already given permission and enable mic turn on and off in between call @slycoder
There was a problem hiding this comment.
Perhaps I'm confused then; this is the only place in the code where LocalAudioTrack.create is called. So if the local participant enabled the mic during the call, where would the track get created?
There was a problem hiding this comment.
May be we can connect related to this if you have bandwidth @slycoder
There was a problem hiding this comment.
I'm afraid I don't have time; I'd prefer to resolve this asynchronously if possible.
There was a problem hiding this comment.
This will not effect we are using same things since many day in our project and it's not creating any issue working fine
not please test at your end and merge it if are comfortable with this Thanks @slycoder
There was a problem hiding this comment.
I just want to make sure that this change doesn't break the use case that some users of the library have where they have permissions but nonetheless want to join the call with the audio initially disabled, but the user can at any time during the call enable the audio.
There was a problem hiding this comment.
Yes it will not break . @slycoder
There was a problem hiding this comment.
LocalAudioTrack.create(getContext(), enableAudio)
This will break the code when permission is not granted @slycoder
That's why we are creating when user enable the audio
|
Also, I'm not entirely clear on what the problem being solved is. According to the documentation, if permissions are not granted, then this should call should return null anyways: |
gastonmorixe
force-pushed
the
master
branch
from
7c3cd06
to
bce7e78
Compare
No description provided.