Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid network timeout on large histories #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/scm/adapters/svn_chain/chain.rb
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,22 @@ def first_token(after=0)

def first_commit(after=0)
@first_commit ||={} # Poor man's memoize
@first_commit[after] ||= Scm::Parsers::SvnXmlParser.parse(next_revision_xml(after)).first
@first_commit[after] ||= Scm::Parsers::SvnXmlParser.parse(next_revision_xml(after)).last
end

# Returns the first commit with a revision number greater than the provided revision number
def next_revision_xml(after=0)
return "<?xml?>" if after.to_i >= head_token
run "svn log --trust-server-cert --non-interactive --verbose --xml --stop-on-copy -r #{after.to_i+1}:#{final_token || 'HEAD'} --limit 1 #{opt_auth} '#{SvnAdapter.uri_encode(File.join(self.root, self.branch_name))}@#{final_token || 'HEAD'}'"
back_to_front = "svn log --trust-server-cert --non-interactive --verbose --xml --stop-on-copy -r #{after.to_i+1}:#{final_token || 'HEAD'} --limit 1 #{opt_auth} '#{SvnAdapter.uri_encode(File.join(self.root, self.branch_name))}@#{final_token || 'HEAD'}'"
front_to_back = "svn log --trust-server-cert --non-interactive --verbose --xml --stop-on-copy -r #{final_token || 'HEAD'}:#{after.to_i+1} #{opt_auth} '#{SvnAdapter.uri_encode(File.join(self.root, self.branch_name))}@#{final_token || 'HEAD'}'"
# if the repository history is so extensive or
# the remote server so slow that the network
# connection times out before there is a
# response, use a slower and more resource
# intensive method that should always succeed:
# receive the revisions in order and extract
# the last entry.
run("#{back_to_front} || #{front_to_back}")
end

# If the passed diff represents the wholesale movement of the entire
Expand Down