Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14897] Enhance build.yml run summary and fix f-droid distribution #4296

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Nov 13, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14897
https://bitwarden.atlassian.net/browse/PM-14898

📔 Objective

Outputs version name and number to action run summary, removing the need to go into job step logs.

While at it, fixed f-droid internal firebase distribution. Thanks @vgrassia for pointing it out!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang added the ci/cd Updates to automated workflows label Nov 13, 2024
@vvolkgang vvolkgang requested a review from a team as a code owner November 13, 2024 11:33
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (e804dbd) to head (8ffe514).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4296   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         453      453           
  Lines       39064    39064           
  Branches     5482     5482           
=======================================
  Hits        34771    34771           
  Misses       2369     2369           
  Partials     1924     1924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details910a78e3-88fc-48b2-8461-6ffe1da04e00

No New Or Fixed Issues Found

@vvolkgang vvolkgang changed the title [PM-14897] Show version name and number in build.ym run summary [PM-14897] Enhance build.yml run summary and fix f-droid distribution Nov 13, 2024
@vvolkgang vvolkgang added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 1e0e483 Nov 13, 2024
9 checks passed
@vvolkgang vvolkgang deleted the build-version-output branch November 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants