Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14553] Make canManage property of collections optional #4284

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Nov 11, 2024

🎟️ Tracking

PM-14553

📔 Objective

This change updates the database schema to allow the canManage property of collections to be nullable. It also updates the data source implementation to handle the nullable value.

If the canManage property is not specified for a collection, assume it is true for non-readonly collections. This ensures that users can manage collections that are not read-only, if the canManage property is not explicitly set.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

If the canManage property is not specified for a collection, assume it is true for non-readonly collections. This ensures that users can manage collections that are not read-only, if the canManage property is not explicitly set.
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Logo
Checkmarx One – Scan Summary & Detailsad83d9a6-70ae-404b-ac33-2290d941b3f8

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (40f33df) to head (289fb9c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4284   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         453      453           
  Lines       38979    38979           
  Branches     5493     5494    +1     
=======================================
  Hits        34680    34680           
  Misses       2373     2373           
  Partials     1926     1926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck changed the title [PM-14553] Default canManage to true for non-readonly collections [PM-14553] Make canManage property of collections optional Nov 14, 2024
This change updates the database schema to allow the `canManage` property of collections to be nullable. It also updates the data source implementation to handle the nullable value.
@SaintPatrck SaintPatrck added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 0a888a7 Nov 14, 2024
9 checks passed
@SaintPatrck SaintPatrck deleted the PM-14553/make-manage-optional branch November 14, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants