Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14805: Ensure results cannot be double wrapped from 'asSuccess' #4283

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Nov 11, 2024

🎟️ Tracking

PM-14805

📔 Objective

This PR ensures that you cannot double wrap a Result in a Result when using the asSuccess helper method.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6f2ba211-d718-4c91-a961-b007e742108b

No New Or Fixed Issues Found

@david-livefront
Copy link
Collaborator Author

Thanks @patrick-bitwarden

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (c529371) to head (3c0c1e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4283   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files         452      452           
  Lines       38945    38947    +2     
  Branches     5478     5479    +1     
=======================================
+ Hits        34654    34656    +2     
  Misses       2369     2369           
  Partials     1922     1922           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 771e719 Nov 11, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-14805-double-wrapped-result branch November 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants