-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforced edge-to-edge #1078
base: main-ose
Are you sure you want to change the base?
Enforced edge-to-edge #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some adjustments.
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/IntroScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now it works 👍
We should probably implement proper edge-to-edge support soon. All good.
Do you mean like merging this or there is something missing on this PR? I mean, it should already implement full edge-to-edge support. |
Right, my bad. I used the wrong emulator once. Forget it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed a view things:
- Theme: The transparent navigation bar was not good on Android <15, the buttons were white on very light grey. I think it's ok like that on Android <15.
- Intro pages: I have used "safe drawing" and consumed top+sides (like TopAppBar) instead of only the status bar padding for the intro pages content, and bottom+sides (like BottomAppBar) for the navigation bar. As I understand it, we shouldn't use only navigation and status bar insets and ignore the other ones, because they may have relevance in some situations. / Also removed the obsolete 90 dp
Spacer
. - Assistant: made clear that it should be used in a Scaffold that handles insets.
@ArnyminerZ Please have a look at the changes + check whether these are working for you. Tested with Android 7.1.1 and 15 in light+dark mode and looked fine here and maybe there are still duplicate/missing insets or so.
I've tried it with Android 14, and there are some odd things. First of all, the intro looks great, but on the home screen drawer, the bottom part is perfect, but I think the top part should be "through the status bar": It's kind of cut-off. Then, when adding an account, the navigation bar color should be lighter I think: As well as in the settings, we can leave it as is if we want that functionality, but right now the content is behind the navigation bar, and not showing through like it theoretically should with edge-to-edge: |
To be honest, it's like I had it in mind:
You mean that the dark background of the branding should completely go to the top as in the TopAppBars, right? Yes, why not. We can do it like that, maybe it looks more consistent with the app bars.
Agreed, can you change it?
Ah I didn't even notice that it should shine through as it doesn't really make sense to me that the content of an app shines through system controls. But that's the whole concept of edge-to-edge, and it seems that it's intended as you say, so yes, I'm for changing that too. |
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
- With transparent, system bar buttons are white on very-light-grey
f13602e
to
f28edc9
Compare
So still to do:
|
Purpose
See #1077
Short description
Window.statusBarColor
with edge-to-edge settings.WindowInsets
to0
inAssistant
since we are using an action bar outside of an Scaffold, and the padding is being applied twice.IME padding is applied automaticallyChecklist