Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add id_from_pos support #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LagginTimes
Copy link

This PR introduces the blockchain.transaction.id_from_pos feature from Electrum. This functionality is essential for an ongoing implementation in bdk_electrum, which requires retrieving the coinbase transaction from a block at a specified height. Currently, there is no straightforward method to achieve this. By implementing the id_from_pos feature, we will effectively address this gap.

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just change naming to be a bit more "conventional". I.e. transaction_id should be txid.

src/api.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 76f7fc8

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a871b08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants