upgrading to match bdk v29 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To get this to build with rust 1.63 you need to copy/paste or cherry-pick this patch: notmandatory@f85cdcc |
|
Hi @notmandatory , the fixes should be in. Please check it, and thanks. |
|
Hello @notmandatory, any update on this? Thank you. |
|
@notmandatory Reminder to check this please. Thanks. |
|
Hey @notmandatory I opened this PR just before going on holiday. Giovanni made all the necessary adjustments. Could you have another look at it? |
|
For some reason the CI didn't run on this PR, can you try re-pushing ? |
ulrichard
force-pushed
the
feature/bdk29
branch
4 times, most recently
from
d83aeb0
to
d391fd8
Compare
notmandatory
requested changes
Aug 21, 2024
CI fix for MSRV 1.63 Co-authored-by: Steve Myers <[email protected]> Co-authored-by: Steve Myers <[email protected]>
ulrichard
force-pushed
the
feature/bdk29
branch
from
d391fd8
to
3295228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.