Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: update requirements of Bitcoin Core 28.0 #251

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

EndrII
Copy link
Contributor

@EndrII EndrII commented Oct 15, 2024

Bitcoin core at now require libc 2.31 to tests,

  • changed build image to Ubuntu 20.04 (It's still deprecated, but we can't move to 24.04 because bitcoin core app still depends on qt5)
  • changed snap core depends on Ubuntu 20 (it's not important but better if build environment will be same as runtime environment)

@maflcko
Copy link
Contributor

maflcko commented Oct 15, 2024

Ref: #248 (comment)

Also, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@EndrII
Copy link
Contributor Author

EndrII commented Oct 15, 2024

Also, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

done

@EndrII EndrII reopened this Oct 15, 2024
@maflcko
Copy link
Contributor

maflcko commented Oct 15, 2024

The unity7 note can be removed from the pull description.

@maflcko
Copy link
Contributor

maflcko commented Oct 15, 2024

See #248 (comment) about the CI failure

@EndrII
Copy link
Contributor Author

EndrII commented Oct 29, 2024

It seems that all efforts should be made to change the image where snapd is already installed. I will continue to work on this later.

@maflcko
Copy link
Contributor

maflcko commented Oct 30, 2024

I tried something in #253, but that didn't work.

@EndrII
Copy link
Contributor Author

EndrII commented Oct 30, 2024

I tried something in #253, but that didn't work.

You tried to run build with multipass (default) it's wrong, it will not work, because multipass works as general VM with kvm system.

i think we should try this. This is an official docer container from canonical with snapcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants