Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "hwi signtx -" #757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow "hwi signtx -" #757

wants to merge 1 commit into from

Conversation

8go
Copy link
Contributor

@8go 8go commented Sep 10, 2024

Enhanced signtx to accept special character - to indicate to read the base64-encoded PSBT from the stdin instead of from the command line. This allows running commands like
xclip -o -selection clipboard | hwi -t <device> signtx -.

Enhanced `signtx` to accept special character `-` to indicate to read
the base64-encoded PSBT from the stdin instead of from the command line.
This allows running commands like
`xclip -o -selection clipboard | hwi -t <device> signtx -`.
@8go 8go mentioned this pull request Sep 10, 2024
@achow101
Copy link
Member

achow101 commented Sep 12, 2024

--stdin already exists to do that.

@8go
Copy link
Contributor Author

8go commented Sep 22, 2024

Ok, I did not realize that. Now I do.

Before I close this PR, a question:

How about an option --clipin to read the PSBT from the clipboard? And a --clipout to write the resulting signed PSBT back onto the clipboard. As in:

# unsigned PSBT is on the clipboard
hwi -t $DEVICE --clipin --clipout signtx 
# signed PSBT is on the clipboard

Would that be a worthwhile PR for me to make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants