Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(capi): Add MUSL Support + SHA256 checksums #239

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ptondereau
Copy link
Contributor

@ptondereau ptondereau commented Nov 3, 2024

  • Add MUSL target
  • Add SHA256 checksums
  • rename release files to biscuit-auth-capi-X.X.X-arch.tar.gz
  • download directly cargo-c instead of compiling
  • Re-activate macos x86 build

@ptondereau ptondereau force-pushed the capi-release-update branch 2 times, most recently from de8914e to f066075 Compare November 3, 2024 21:12
@ptondereau ptondereau marked this pull request as ready for review November 3, 2024 21:14
Copy link

codspeed-hq bot commented Nov 3, 2024

CodSpeed Performance Report

Merging #239 will not alter performance

Comparing ptondereau:capi-release-update (9f35b7e) with main (6ccb7aa)

Summary

✅ 12 untouched benchmarks

# deactivated for now, the x86 workers are more expensive
# - os: macos-latest-large
# target_arch: x86_64-apple-darwin
- os: macos-13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geal
Copy link
Contributor

Geal commented Nov 4, 2024

@ptondereau it looks like it will work. Do you feel there's anything to add?

@ptondereau
Copy link
Contributor Author

@ptondereau it looks like it will work. Do you feel there's anything to add?

For the moment that's enough to start with I'll try to follow what has been done for the wasm plugin with C API then

@Geal Geal merged commit 4fc3c31 into biscuit-auth:main Nov 5, 2024
5 checks passed
@ptondereau ptondereau deleted the capi-release-update branch November 5, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants